Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user config + default config merge for MeterProvider, Meter #1491

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

naseemkullah
Copy link
Member

@naseemkullah naseemkullah commented Sep 3, 2020

Please review #1493 first, it is simpler than this PR, but shares some similarities.

Which problem is this PR solving?

Short description of the changes

@naseemkullah

Member
naseemkullah commented on Sep 3 •
Which problem is this PR solving?
partially #1417

Short description of the changes

  • Deep merge user supplied Meter and MeterProvider configs into default config by means of lodash.merge

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1491 (da3f4f5) into master (f6702bd) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1491      +/-   ##
==========================================
- Coverage   92.49%   92.30%   -0.20%     
==========================================
  Files         173      169       -4     
  Lines        6038     5728     -310     
  Branches     1284     1236      -48     
==========================================
- Hits         5585     5287     -298     
+ Misses        453      441      -12     
Impacted Files Coverage Δ
packages/opentelemetry-metrics/src/Meter.ts 88.69% <100.00%> (+0.30%) ⬆️
...ackages/opentelemetry-metrics/src/MeterProvider.ts 89.47% <100.00%> (+1.23%) ⬆️
...mentation-xml-http-request/src/enums/EventNames.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...-instrumentation-fetch/src/enums/AttributeNames.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@naseemkullah naseemkullah changed the title fix: meter(Provider) user config + default config merge feat: user config + default config merge for MeterProvider, Meter and TracerProvider Sep 3, 2020
@naseemkullah naseemkullah changed the title feat: user config + default config merge for MeterProvider, Meter and TracerProvider feat: user config + default config merge for MeterProvider, Meter Sep 3, 2020
@naseemkullah
Copy link
Member Author

Please review #1493 first, it is simpler than this PR, but shares some similarities.

@naseemkullah
Copy link
Member Author

lint failing in untouched file /home/runner/work/opentelemetry-js/opentelemetry-js/packages/opentelemetry-web/src/utils.ts

/home/runner/work/opentelemetry-js/opentelemetry-js/packages/opentelemetry-web/src/utils.ts
  128:70  error  Replace `⏎····PerformanceResourceTiming⏎··` with `PerformanceResourceTiming`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

@naseemkullah naseemkullah merged commit fdb5b53 into open-telemetry:master Jan 15, 2021
@naseemkullah naseemkullah deleted the default-values-fix branch January 15, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace and Meter Provider Specs Defaults
3 participants