-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user config + default config merge for MeterProvider, Meter #1491
Merged
naseemkullah
merged 3 commits into
open-telemetry:master
from
naseemkullah:default-values-fix
Jan 15, 2021
Merged
feat: user config + default config merge for MeterProvider, Meter #1491
naseemkullah
merged 3 commits into
open-telemetry:master
from
naseemkullah:default-values-fix
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
commented
Sep 3, 2020
naseemkullah
commented
Sep 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
- Coverage 92.49% 92.30% -0.20%
==========================================
Files 173 169 -4
Lines 6038 5728 -310
Branches 1284 1236 -48
==========================================
- Hits 5585 5287 -298
+ Misses 453 441 -12
|
naseemkullah
changed the title
fix: meter(Provider) user config + default config merge
feat: user config + default config merge for MeterProvider, Meter and TracerProvider
Sep 3, 2020
naseemkullah
changed the title
feat: user config + default config merge for MeterProvider, Meter and TracerProvider
feat: user config + default config merge for MeterProvider, Meter
Sep 3, 2020
Please review #1493 first, it is simpler than this PR, but shares some similarities. |
naseemkullah
force-pushed
the
default-values-fix
branch
from
September 3, 2020 05:03
de07a77
to
e7f8129
Compare
naseemkullah
force-pushed
the
default-values-fix
branch
from
November 28, 2020 03:27
82c8352
to
9f0530f
Compare
naseemkullah
commented
Nov 28, 2020
naseemkullah
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
November 28, 2020 03:29
lint failing in untouched file
|
naseemkullah
force-pushed
the
default-values-fix
branch
from
December 8, 2020 02:14
3b220d1
to
64473b6
Compare
vmarchaud
approved these changes
Dec 8, 2020
Signed-off-by: Naseem <[email protected]>
naseemkullah
force-pushed
the
default-values-fix
branch
from
January 4, 2021 01:48
3bc0af5
to
647c75d
Compare
dyladan
approved these changes
Jan 13, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review #1493 first, it is simpler than this PR, but shares some similarities.
Which problem is this PR solving?
Short description of the changes
@naseemkullah
Member
naseemkullah commented on Sep 3 •
Which problem is this PR solving?
partially #1417
Short description of the changes