-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: lint markdown files #1147
Merged
naseemkullah
merged 4 commits into
open-telemetry:master
from
naseemkullah:lint-markdown
Jun 8, 2020
Merged
ci: lint markdown files #1147
naseemkullah
merged 4 commits into
open-telemetry:master
from
naseemkullah:lint-markdown
Jun 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
force-pushed
the
lint-markdown
branch
2 times, most recently
from
June 7, 2020 03:38
70e43c8
to
21cec07
Compare
Codecov Report
@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 92.32% 92.29% -0.03%
==========================================
Files 116 116
Lines 3402 3402
Branches 689 689
==========================================
- Hits 3141 3140 -1
- Misses 261 262 +1
|
naseemkullah
force-pushed
the
lint-markdown
branch
5 times, most recently
from
June 7, 2020 15:43
aa33b57
to
bae4e2c
Compare
Signed-off-by: Naseem <[email protected]>
Signed-off-by: Naseem <[email protected]>
Signed-off-by: Naseem <[email protected]>
Signed-off-by: Naseem <[email protected]>
naseemkullah
force-pushed
the
lint-markdown
branch
from
June 7, 2020 15:50
ca75232
to
b83e981
Compare
naseemkullah
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
mwear,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
June 7, 2020 15:51
mayurkale22
approved these changes
Jun 8, 2020
dyladan
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change thanks!
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* ci: add markdown linting Signed-off-by: Naseem <[email protected]> * fix: lint markdown files Signed-off-by: Naseem <[email protected]> * docs: add markdown lint configuration Signed-off-by: Naseem <[email protected]> * docs: lint change log Signed-off-by: Naseem <[email protected]>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* ci: add markdown linting Signed-off-by: Naseem <[email protected]> * fix: lint markdown files Signed-off-by: Naseem <[email protected]> * docs: add markdown lint configuration Signed-off-by: Naseem <[email protected]> * docs: lint change log Signed-off-by: Naseem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
.markdownlint.json
to facilitate integrating this into the CI (we can choose to remove any number of these rules from being ignored in subsequent PRs)Special Notes
Please ignore whitespace changes for a better review experience.
It would be nice to get this in sooner than later since rebasing from other commits that include doc changes will be burdensome. 😬