-
Notifications
You must be signed in to change notification settings - Fork 821
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Naseem <[email protected]>
- Loading branch information
Naseem
committed
Jun 7, 2020
1 parent
d909bf1
commit aa33b57
Showing
41 changed files
with
316 additions
and
153 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,16 +25,19 @@ The Conventional Commits specification is a lightweight convention on top of com | |
We use [commitlint](https://github.com/conventional-changelog/commitlint) and [husky](https://github.com/typicode/husky) to prevent bad commit message. | ||
For example, you want to submit the following commit message `git commit -s -am "my bad commit"`. | ||
You will receive the following error : | ||
|
||
``` | ||
✖ type must be one of [ci, feat, fix, docs, style, refactor, perf, test, revert, chore] [type-enum] | ||
``` | ||
|
||
Here an exemple that will pass the verification: `git commit -s -am "chore(opentelemetry-core): update deps"` | ||
|
||
### Fork | ||
|
||
In the interest of keeping this repository clean and manageable, you should work from a fork. To create a fork, click the 'Fork' button at the top of the repository, then clone the fork locally using `git clone [email protected]:USERNAME/opentelemetry-js.git`. | ||
|
||
You should also add this repository as an "upstream" repo to your local copy, in order to keep it up to date. You can add this as a remote like so: | ||
|
||
``` | ||
git remote add upstream https://github.com/open-telemetry/opentelemetry-js.git | ||
|
@@ -43,6 +46,7 @@ git remote -v | |
``` | ||
|
||
To update your fork, fetch the upstream repo's branches and commits, then merge your master with upstream's master: | ||
|
||
``` | ||
git fetch upstream | ||
git checkout master | ||
|
@@ -90,12 +94,15 @@ The `opentelemetry-js` project is written in TypeScript. | |
- New or changed functionality is documented. | ||
|
||
### Generating API documentation | ||
|
||
- `npm run docs` to generate API documentation. Generates the documentation in `packages/opentelemetry-api/docs/out` | ||
|
||
### Generating CHANGELOG documentation | ||
|
||
- `npm run changelog` to generate CHANGELOG documentation in your terminal (see [RELEASING.md](RELEASING.md) for more details). | ||
|
||
### Benchmarks | ||
|
||
When two or more approaches must be compared, please write a benchmark in the benchmark/index.js module so that we can keep track of the most efficient algorithm. | ||
|
||
- `npm run bench` to run your benchmark. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.