Skip to content

Commit

Permalink
Merge d09fdf2 into 9945c4b
Browse files Browse the repository at this point in the history
  • Loading branch information
pichlermarc authored Apr 13, 2023
2 parents 9945c4b + d09fdf2 commit ac51fef
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,11 @@ These instrumentations are hosted at <https://github.com/open-telemetry/opentele

## Upgrade guidelines

### 0.37.x to 0.38.0

- `@opentelemetry/sdk-node` `NodeSDKConfiguration.defaultAttributes` has been unused and was removed as the concept does not exist in OpenTelemetry anymore
- Please use `NodeSDKConfiguration.resource` instead.

### 0.35.x to 0.36.0

- `@opentelemetry/sdk-node` changed `await start()` to now be synchronous
Expand Down
3 changes: 3 additions & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ All notable changes to experimental packages in this project will be documented

### :boom: Breaking Change

* fix(sdk-node)!: remove unused defaultAttributes option [#3724](https://github.com/open-telemetry/opentelemetry-js/pull/3724) @pichlermarc
* Please use `NodeSDKConfiguration.resource` instead

### :rocket: (Enhancement)

### :bug: (Bug Fix)
Expand Down
3 changes: 1 addition & 2 deletions experimental/packages/opentelemetry-sdk-node/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import type { ContextManager, SpanAttributes } from '@opentelemetry/api';
import type { ContextManager } from '@opentelemetry/api';
import { TextMapPropagator } from '@opentelemetry/api';
import { InstrumentationOption } from '@opentelemetry/instrumentation';
import { Detector, DetectorSync, Resource } from '@opentelemetry/resources';
Expand All @@ -30,7 +30,6 @@ import {
export interface NodeSDKConfiguration {
autoDetectResources: boolean;
contextManager: ContextManager;
defaultAttributes: SpanAttributes;
textMapPropagator: TextMapPropagator;
metricReader: MetricReader;
views: View[];
Expand Down

0 comments on commit ac51fef

Please sign in to comment.