fix(opentelemetry-sdk-trace-web): don't crash in runtimes where locat…

…ion isn't defined (#3715) * fix(opentelemetry-sdk-trace-web): don't crash in runtimes where location isn't defined * chore: updated changelog * chore(opentelemetry-sdk-trace-web): fix linter issues * fix(opentelemetry-sdk-trace-web): Remove broken test and replace with comment --------- Co-authored-by: Daniel Dyla <[email protected]>
open-telemetry · Apr 12, 2023 · 9945c4b · 9945c4b
1 parent 9328558
commit 9945c4b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
 ### :bug: (Bug Fix)
 
 * fix(instrumentation-http): fixed description for http.server.duration metric [#3710](https://github.com/open-telemetry/opentelemetry-js/pull/3710)
+* fix(opentelemetry-sdk-trace-web): don't crash in runtimes where location isn't defined [#3715](https://github.com/open-telemetry/opentelemetry-js/pull/3715)
 
 ### :books: (Refine Doc)
 

diff --git a/packages/opentelemetry-sdk-trace-web/src/utils.ts b/packages/opentelemetry-sdk-trace-web/src/utils.ts
@@ -307,7 +307,11 @@ export function parseUrl(url: string): URLLike {
   if (typeof URL === 'function') {
     return new URL(
       url,
-      typeof document !== 'undefined' ? document.baseURI : location.href
+      typeof document !== 'undefined'
+        ? document.baseURI
+        : typeof location !== 'undefined' // Some JS runtimes (e.g. Deno) don't define this
+        ? location.href
+        : undefined
     );
   }
   const element = getUrlNormalizingAnchor();