Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core deps to 0.24.0 #594

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jul 28, 2021

No description provided.

@dyladan dyladan requested a review from a team July 28, 2021 14:19
@dyladan dyladan added the enhancement New feature or request label Jul 28, 2021
@vmarchaud
Copy link
Member

There was someone that had a PR to handle the breaking changes for semantic convention name here: #578, i guess its easier to have it in this PR ?

@dyladan
Copy link
Member Author

dyladan commented Jul 28, 2021

The build won't pass for that PR without these changes and this build won't pass without those changes so they need to be done in one PR

@syncush
Copy link
Contributor

syncush commented Jul 28, 2021

@dyladan I was waiting for the v0.24.x release to I can update all core deps in my PR, but you've already done it 😃

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #594 (a7b2d46) into main (fc70b9a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   94.76%   94.78%   +0.02%     
==========================================
  Files         176      179       +3     
  Lines       10702    10976     +274     
  Branches     1020     1088      +68     
==========================================
+ Hits        10142    10404     +262     
- Misses        560      572      +12     
Impacted Files Coverage Δ
...ry-instrumentation-user-interaction/src/version.ts 100.00% <0.00%> (ø)
...umentation-user-interaction/src/instrumentation.ts 95.48% <0.00%> (ø)
...ation-user-interaction/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)

@dyladan dyladan merged commit 99e1472 into open-telemetry:main Jul 28, 2021
@dyladan dyladan deleted the core-24 branch July 28, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants