refactor: renamed ResourceAttributes to SemanticResourceAttributes (#574) #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncush
force-pushed
the
syncush/574
branch
2 times, most recently
from
06bc629 to
8b61034
Compare
|
Update: waiting for a release, open-telemetry/opentelemetry-js#2345 is merged |
|
This build cannot pass without also updating the deps and my deps PR can't pass without incorporating these changes. Closing in favor of #594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
ResourceAttributestoSemanticResourceAttributesin order to follow v1.5.0 of @opentelemetry/semantic-conventionsBlocked by open-telemetry/opentelemetry-js#2345