-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix semantic conventions for PG and PG Pool #467
Fix semantic conventions for PG and PG Pool #467
Conversation
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
==========================================
- Coverage 95.29% 95.23% -0.07%
==========================================
Files 131 130 -1
Lines 8116 8325 +209
Branches 751 811 +60
==========================================
+ Hits 7734 7928 +194
- Misses 382 397 +15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked because your local path is in the example package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
d5c4397
to
a7bcd61
Compare
Which problem is this PR solving?
This should fix #116, #296, #297 and #465
Short description of the changes
Replace all official semantic conventions with their values from @opentelemetry/semantic-conventions package.
Leave some of the old custom attributes as they are, but put them into a namespace db.postgresql (while not officialy stated in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md) there are some other examples with db.<db.system>, e.g. db.mssql.instance_name or db.mongodb.collection