Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL instrumentation uses wrong attributes #465

Closed
pauldraper opened this issue May 2, 2021 · 4 comments · Fixed by #467
Closed

PostgreSQL instrumentation uses wrong attributes #465

pauldraper opened this issue May 2, 2021 · 4 comments · Fixed by #467
Assignees
@svrnm
Labels
bug Something isn't working

Comments

@pauldraper
Copy link
Contributor

https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-pg/src/enums.ts

Instead of net.peer.host (the semantic convention) the instrumentation uses peer.host. Etc.
@pauldraper pauldraper added the bug Something isn't working label May 2, 2021
@svrnm svrnm mentioned this issue May 4, 2021
Merged
@dyladan dyladan linked a pull request May 5, 2021 that will close this issue
Fix semantic conventions for PG and PG Pool #467
Merged
@svrnm
Copy link
Member

svrnm commented May 5, 2021

I can take this.

@pauldraper
Copy link
Contributor Author

While you're at it, probably makes sense to use SemanticAttributes in @opentelemetry/semantic-conventions

@svrnm
Copy link
Member

svrnm commented May 5, 2021

@pauldraper the PR #467 should cover that, please double check if I missed anything!:-)

@obecny
Copy link
Member

obecny commented May 5, 2021

@svrnm can I assign this to you then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svrnm svrnm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix semantic conventions for PG and PG Pool svrnm/opentelemetry-js-contrib
3 participants
@obecny @pauldraper @svrnm