Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move xray propagators back to contrib #2411

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

  • the spec prohibits us from hosting vendor propagators in the core repo. From the spec:

Additional Propagators implementing vendor-specific protocols such as AWS
X-Ray trace header protocol MUST NOT be maintained or distributed as part of
the Core OpenTelemetry repositories.

Short description of the changes

  • moves the xray and xray lambda propagators back to contrib
  • adapts dependencies and lifecycle scripts to contrib repo.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (dfb2dff) to head (1dda06f).
Report is 226 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2411      +/-   ##
==========================================
- Coverage   90.97%   90.77%   -0.20%     
==========================================
  Files         146      158      +12     
  Lines        7492     7722     +230     
  Branches     1502     1596      +94     
==========================================
+ Hits         6816     7010     +194     
- Misses        676      712      +36     
Files with missing lines Coverage Δ
...tor-aws-xray-lambda/src/AWSXRayLambdaPropagator.ts 100.00% <100.00%> (ø)
...ators/propagator-aws-xray/src/AWSXRayPropagator.ts 100.00% <100.00%> (ø)

... and 76 files with indirect coverage changes

@pichlermarc pichlermarc requested a review from a team as a code owner October 18, 2024 08:32
@pichlermarc pichlermarc merged commit 836ae2d into open-telemetry:main Oct 21, 2024
17 checks passed
@pichlermarc pichlermarc deleted the chore/move-xray-propagators branch October 21, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants