Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Labels Request - propagator: aws:xray and propagator: aws:xray:lambda #4964

Closed
jj22ee opened this issue Aug 29, 2024 · 2 comments
Closed

Comments

@jj22ee
Copy link
Contributor

jj22ee commented Aug 29, 2024

Hello, I'm reaching out on behalf of the AWS X-Ray team. We would like to request the addition of new labels to opentelemetry-js repository: propagator: aws:xray and propagator: aws:xray:lambda. These labels would be used for PRs and issues pertaining to the X-Ray Propagator and X-Ray Lambda Propagator. Ideally, there would be automation that adds these labels to PRs touching X-Ray component code - we would be happy to help with this if some guidance was provided.

Our goal is to have labelling across open-telemetry repositories so that we can find PRs and issues related to the X-Ray components and give faster support to the OTEL community.

Thank you.

@pichlermarc
Copy link
Member

Hi @jj22ee thanks for reaching out. We've been meaning to move the propagators to the js-contrib repo for a while now as we saw that hosting vendor components in the here in the core repo is not spec compliant.

I've opened a PR to add them to contrib open-telemetry/opentelemetry-js-contrib#2411 as well as a PR to remove them from the core repository here #4966 (marked as draft for now until the contrib PR is merged). In the repository over there, we have some auto-labelling workflow that applies pkg:propagator-aws-xray and pkg:propagator-aws-xray-lambda labels. Would these work for you?

@jj22ee
Copy link
Contributor Author

jj22ee commented Oct 11, 2024

Hi @pichlermarc, sorry for the late reply, been a busy month.
The auto-labelling should work for us, thanks!

@jj22ee jj22ee closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants