Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: rename span#context() to span#spanContext #45

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 23, 2021

Fixes #35

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #45 (9538416) into main (c1f302e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9538416 differs from pull request most recent head f753b24. Consider uploading reports for the commit f753b24 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          39       39           
  Lines         501      501           
  Branches       81       81           
=======================================
  Hits          474      474           
  Misses         27       27           
Impacted Files Coverage Δ
src/context/context.ts 92.50% <100.00%> (ø)
src/trace/NonRecordingSpan.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1f302e...f753b24. Read the comment docs.

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry in upgrade guideline

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, are there going to be a huge corresponding PR is core and contrib ?

@dyladan
Copy link
Member Author

dyladan commented Apr 26, 2021

lgtm, are there going to be a huge corresponding PR is core and contrib ?

yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming Span.context() to spanContext()
4 participants