Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Consider renaming Span.context() to spanContext() #35

Closed
carlosalberto opened this issue Apr 20, 2021 · 2 comments · Fixed by #45
Closed

Consider renaming Span.context() to spanContext() #35

carlosalberto opened this issue Apr 20, 2021 · 2 comments · Fixed by #45
Assignees
@dyladan

Comments

@carlosalberto
Copy link

I remember in some other SIG seeing users complain that getContext() or context() can be confusing/distracting, and having a longer name could be a good thing.

For your consideration ;)
@dyladan
Copy link
Member

dyladan commented Apr 21, 2021

Do you mean rename it to span.spanContext() or have some top-level function named spanContext(span)?

@dyladan dyladan self-assigned this Apr 21, 2021
@dyladan
Copy link
Member

dyladan commented Apr 23, 2021

@carlosalberto ?

@dyladan dyladan mentioned this issue Apr 23, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dyladan dyladan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename span#context() to span#spanContext dyladan/opentelemetry-js-api
2 participants
@carlosalberto @dyladan