Make description of Samplers Locale independent - #4887
Conversation
Codecov ReportBase: 90.83% // Head: 90.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4887 +/- ##
============================================
- Coverage 90.83% 90.83% -0.01%
- Complexity 4856 4859 +3
============================================
Files 556 556
Lines 14474 14483 +9
Branches 1410 1410
============================================
+ Hits 13148 13155 +7
- Misses 908 909 +1
- Partials 418 419 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
left a comment
There was a problem hiding this comment.
Just one small comment. Thanks!
Changed. |
trask
left a comment
There was a problem hiding this comment.
@jack-berg what do you think about calculating it once in the constructor? getDescription is not supposed to be called a lot, but just in case...
and I think the extra small amount of memory is ok since there shouldn't be a huge number of Sampler instances
Fixes: #4880