Bump errorProneVersion from 2.29.2 to 2.30.0 - #3835
Merged
Merged
Conversation
Bumps `errorProneVersion` from 2.29.2 to 2.30.0. Updates `com.google.errorprone:error_prone_annotations` from 2.29.2 to 2.30.0 - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.29.2...v2.30.0) Updates `com.google.errorprone:error_prone_core` from 2.29.2 to 2.30.0 - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.29.2...v2.30.0) --- updated-dependencies: - dependency-name: com.google.errorprone:error_prone_annotations dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.google.errorprone:error_prone_core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
requested review from
Harsimar Kaur (harsimar),
Helen (heyams),
Jean Bisutti (jeanbisutti),
Ram Thiru (ramthi) and
Trask Stalnaker (trask)
as code owners
August 12, 2024 03:54
dependabot
Bot
added
dependencies
Trask Stalnaker (trask)
requested a review
from John (johnoliver)
as a code owner
August 12, 2024 03:56
Helen (heyams)
approved these changes
Aug 12, 2024
| Set<ObjectName> objects = server.queryNames(new ObjectName(objectName), null); | ||
| if (objects.isEmpty()) { | ||
| String errorMsg = String.format("Cannot find object name '%s'", objectName); | ||
| String errorMsg = String.format(Locale.ROOT, "Cannot find object name '%s'", objectName); |
Member
There was a problem hiding this comment.
just fyi, I usually replace this type of String.format usage with string concatenation, similar to upstream: open-telemetry/opentelemetry-java#4887 (comment)
| Map<String, String> io = | ||
| FileUtil.getKeyValueMapFromFile(String.format(ProcPath.PID_IO, processId), ":"); | ||
| FileUtil.getKeyValueMapFromFile( | ||
| String.format(Locale.ROOT, ProcPath.PID_IO, processId), ":"); |
Contributor
There was a problem hiding this comment.
this is better to use string.format. pattern is inside PID_IO constant.
Comment on lines
+110
to
+114
| sb.append(String.format(Locale.ROOT, "%02d.", days)); | ||
| } | ||
| sb.append(String.format("%02d:%02d:%02d", hours, minutes, seconds)); | ||
| sb.append(String.format(Locale.ROOT, "%02d:%02d:%02d", hours, minutes, seconds)); | ||
| if (milliseconds > 0) { | ||
| sb.append(String.format(".%03d0000", milliseconds)); | ||
| sb.append(String.format(Locale.ROOT, ".%03d0000", milliseconds)); |
Contributor
There was a problem hiding this comment.
same here.. it's better to using string.format to keep number of digits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
errorProneVersionfrom 2.29.2 to 2.30.0.Updates
com.google.errorprone:error_prone_annotationsfrom 2.29.2 to 2.30.0Release notes
Sourced from com.google.errorprone:error_prone_annotations's releases.
Commits
5ada179Release Error Prone 2.30.0af175b0Don't fire theCanIgnoreReturnValueSuggesterfor `dagger.producers.Producti...ba8f9a2Do not update getters that override methods from a superclass.a706e8dAdd ability to suppress warning for the entire AutoValue class86df5cfConvert some simple blocks to return switches usingyield474554aRemove// fall outcomments, which are sometimes used to document an empty ...ac7ebf5Handlevarin MustBeClosedCheckerccd3ca6Add handling of toBuilder()d887307Omit some unnecessary break statements when translating to->switchesfe07236Add Error Prone check for unnecessary boxed types in AutoValue classes.Updates
com.google.errorprone:error_prone_corefrom 2.29.2 to 2.30.0Release notes
Sourced from com.google.errorprone:error_prone_core's releases.
Commits
5ada179Release Error Prone 2.30.0af175b0Don't fire theCanIgnoreReturnValueSuggesterfor `dagger.producers.Producti...ba8f9a2Do not update getters that override methods from a superclass.a706e8dAdd ability to suppress warning for the entire AutoValue class86df5cfConvert some simple blocks to return switches usingyield474554aRemove// fall outcomments, which are sometimes used to document an empty ...ac7ebf5Handlevarin MustBeClosedCheckerccd3ca6Add handling of toBuilder()d887307Omit some unnecessary break statements when translating to->switchesfe07236Add Error Prone check for unnecessary boxed types in AutoValue classes.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)