Skip to content

Add toString method to AbstractInstrument #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jack-berg merged 3 commits into from
Oct 25, 2022
Merged

Add toString method to AbstractInstrument #4883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6591edd
Add toString method to AbstractInstrument
mkorzeniewski Oct 24, 2022
65aa08c
add test for toString method
mkorzeniewski Oct 25, 2022
ffdf04e
use hasToString assertion for toString test
mkorzeniewski Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,9 @@ public boolean equals(@Nullable Object o) {
public int hashCode() {
return descriptor.hashCode();
}

@Override
public String toString() {
return this.getClass().getSimpleName() + "{" + "descriptor=" + getDescriptor() + '}';
}
}
7 changes: 7 additions & 0 deletions sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/AbstractInstrumentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ void getValues() {
assertThat(testInstrument.getDescriptor()).isSameAs(INSTRUMENT_DESCRIPTOR);
}

@Test
void testToString() {
TestInstrument testInstrument = new TestInstrument(INSTRUMENT_DESCRIPTOR);
assertThat(testInstrument)
.hasToString("TestInstrument{descriptor=" + INSTRUMENT_DESCRIPTOR + "}");
}

private static final class TestInstrument extends AbstractInstrument {
TestInstrument(InstrumentDescriptor descriptor) {
super(descriptor);
Expand Down