Add toString method to AbstractInstrument - #4883
Merged
jack-berg merged 3 commits intoOct 25, 2022
Merged
Conversation
|
|
mkorzeniewski
force-pushed
the
issue-4829-add-tostring-to-classes-from-metrics-package
branch
from
October 25, 2022 05:56
666aaf3 to
05cac6e
Compare
|
|
mkorzeniewski
force-pushed
the
issue-4829-add-tostring-to-classes-from-metrics-package
branch
from
October 25, 2022 05:57
05cac6e to
6591edd
Compare
Contributor
Author
|
force push to the branch with author e-mail change |
Codecov ReportBase: 90.79% // Head: 90.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4883 +/- ##
============================================
+ Coverage 90.79% 90.83% +0.04%
- Complexity 4844 4857 +13
============================================
Files 555 556 +1
Lines 14438 14475 +37
Branches 1405 1410 +5
============================================
+ Hits 13109 13149 +40
+ Misses 910 908 -2
+ Partials 419 418 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves: #4829
I have added a
toStringmethod to the abstract class to make it available for every implementation of the AbstractInstrument. I believe the better way would be adding toString method to each the subclasses, but I would appreciate a piece of advice here.Sample toString for the SdkDoubleHistogram is: