(4172) Vararg versions of AttributeBuilder.put - #4188
Merged
jkwatson merged 11 commits intoFeb 24, 2022
Conversation
gcatanese
requested review from
anuraaga,
carlosalberto,
jack-berg,
jkwatson and
jsuereth
as code owners
February 18, 2022 08:32
anuraaga
reviewed
Feb 18, 2022
* Add experimental view config module * Rename view-config to metric-incubator * Switch naming from camelCase to snake_case * Extend with attribute key filter * Wire up to autoconfiguration * Use snakeyaml instead of jackson * PR feedback * PR feedback
anuraaga
reviewed
Feb 21, 2022
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #4188 +/- ##
============================================
+ Coverage 90.33% 90.37% +0.04%
- Complexity 4746 4750 +4
============================================
Files 548 548
Lines 14551 14554 +3
Branches 1393 1393
============================================
+ Hits 13144 13153 +9
+ Misses 950 946 -4
+ Partials 457 455 -2
Continue to review full report at Codecov.
|
anuraaga
approved these changes
Feb 23, 2022
Contributor
|
This PR has a ton of unrelated changes in it. It probably needs to rebased onto the main branch. |
jkwatson
approved these changes
Feb 24, 2022
jack-berg
approved these changes
Feb 24, 2022
Contributor
|
all maintainers approve! Let's |
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-java
that referenced
this pull request
Feb 25, 2022
* Overload put with AttributeKey with String array * Use generic instead of String * Format and javadoc * Cast to type * New public method * File based view configuration (open-telemetry#4163) * Add experimental view config module * Rename view-config to metric-incubator * Switch naming from camelCase to snake_case * Extend with attribute key filter * Wire up to autoconfiguration * Use snakeyaml instead of jackson * PR feedback * PR feedback * Remove explicit okio dependency (open-telemetry#4187) * Deprecate PrometheusCollector (open-telemetry#4185) * Correct javadoc Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> * Cast to type Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@anuraaga Given the first shot at it, please let me if I understood correctly what you had in mind. Thanks