Deprecate PrometheusCollector - #4185
Merged
anuraaga merged 1 commit intoFeb 21, 2022
Merged
Conversation
anuraaga
requested review from
carlosalberto,
jack-berg,
jkwatson and
jsuereth
as code owners
February 18, 2022 06:36
Codecov Report
@@ Coverage Diff @@
## main #4185 +/- ##
=========================================
Coverage 90.25% 90.25%
Complexity 4660 4660
=========================================
Files 539 539
Lines 14330 14330
Branches 1371 1371
=========================================
Hits 12934 12934
Misses 943 943
Partials 453 453
Continue to review full report at Codecov.
|
jkwatson
approved these changes
Feb 19, 2022
jkwatson
left a comment
jkwatson
left a comment
Contributor
There was a problem hiding this comment.
Seems like this is a good technique to get feedback!
jack-berg
approved these changes
Feb 20, 2022
gcatanese
pushed a commit
to gcatanese/opentelemetry-java
that referenced
this pull request
Feb 21, 2022
jkwatson
pushed a commit
that referenced
this pull request
Feb 24, 2022
* Overload put with AttributeKey with String array * Use generic instead of String * Format and javadoc * Cast to type * New public method * File based view configuration (#4163) * Add experimental view config module * Rename view-config to metric-incubator * Switch naming from camelCase to snake_case * Extend with attribute key filter * Wire up to autoconfiguration * Use snakeyaml instead of jackson * PR feedback * PR feedback * Remove explicit okio dependency (#4187) * Deprecate PrometheusCollector (#4185) * Correct javadoc Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> * Cast to type Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-java
that referenced
this pull request
Feb 25, 2022
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-java
that referenced
this pull request
Feb 25, 2022
* Overload put with AttributeKey with String array * Use generic instead of String * Format and javadoc * Cast to type * New public method * File based view configuration (open-telemetry#4163) * Add experimental view config module * Rename view-config to metric-incubator * Switch naming from camelCase to snake_case * Extend with attribute key filter * Wire up to autoconfiguration * Use snakeyaml instead of jackson * PR feedback * PR feedback * Remove explicit okio dependency (open-telemetry#4187) * Deprecate PrometheusCollector (open-telemetry#4185) * Correct javadoc Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> * Cast to type Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't mind extracting this into an extension right away but wonder what people think of just deprecating for this release and see if we get feedback. Yes it's weird to deprecate prometheus with a reference to micrometer integration :) But I think in practice it's much more common to be using micrometer than the prometheus library directly so want to see if it's enough. For reference, unlike
setChannelwith the similar strategy, this module is still alpha.