Don't use non-fixed test name for akka executor #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Aug 9, 2020
trask
approved these changes
Aug 9, 2020
mabdinur
pushed a commit
to mabdinur/opentelemetry-java-instrumentation
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this fixes the issue in https://15978-210933087-gh.circle-artifacts.com/0/reports/instrumentation/akka-http-10.0/tests/test/classes/AkkaHttpServerInstrumentationTestAsync.html where this akka-http test isn't showing any retries in the report. But locally the test did retry when I modified it to fail - will need to dig more for that.
But the akka-context-propagation error is more obvious, Gradle doesn't like the test name changing every run (because Executor.toString includes object ID). I wouldn't be surprised if Spock retry didn't either and just didn't tell us, but didn't confirm this.
For #926