Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gradle retry doesn't seem to be working for AkkaHttpServerInstrumentationTestAsync #926

Closed
trask opened this issue Aug 8, 2020 · 4 comments
Labels
contributor experience Something that we can do to improve the experience of contributors (especially new contributors)

Comments

@trask
Copy link
Member

trask commented Aug 8, 2020

If my understanding is correct, this failure should have been retried:
https://15978-210933087-gh.circle-artifacts.com/0/reports/instrumentation/akka-http-10.0/tests/test/classes/AkkaHttpServerInstrumentationTestAsync.html

(this build was after merging in latest master so has the new gradle retry config)

@trask
Copy link
Member Author

trask commented Aug 8, 2020

AkkaExecutorInstrumentationTest is also not retrying.

To repro locally, add

ext {
  retryTests = true
}

to akka-context-propagation.gradle

and change something in AkkaExecutorInstrumentationTest to cause it to fail

and run:

./gradlew :instrumentation:akka-context-propagation:test --info --stacktrace

and it should fail with:

Execution failed for task ':instrumentation:akka-context-propagation:test'.
> org.gradle.test-retry was unable to retry the following test methods, which is unexpected. Please file a bug report at https://github.com/gradle/test-retry-gradle-plugin/issues
     AkkaExecutorInstrumentationTest#akka.dispatch.forkjoin.ForkJoinPool@139d3ed5[Running, parallelism = 12, size = 0, active = 0, running = 0, steals = 0, tasks = 0, submissions = 0] 'invoke ForkJoinTask' propagates
     AkkaExecutorInstrumentationTest#akka.dispatch.forkjoin.ForkJoinPool@3bed3ad7[Running, parallelism = 12, size = 0, active = 0, running = 0, steals = 0, tasks = 0, submissions = 0] 'execute ForkJoinTask' propagates
     AkkaExecutorInstrumentationTest#akka.dispatch.forkjoin.ForkJoinPool@34ef8759[Running, parallelism = 12, size = 0, active = 0, running = 0, steals = 0, tasks = 0, submissions = 0] 'submit Runnable' propagates
     AkkaExecutorInstrumentationTest#akka.dispatch.forkjoin.ForkJoinPool@221fe5a2[Running, parallelism = 12, size = 0, active = 0, running = 0, steals = 0, tasks = 0, submissions = 0] 'submit ForkJoinTask' propagates
     AkkaExecutorInstrumentationTest#akka.dispatch.forkjoin.ForkJoinPool@7ea5e33e[Running, parallelism = 12, size = 0, active = 0, running = 0, steals = 0, tasks = 0, submissions = 0] 'execute Runnable' propagates

@trask trask added contributor experience Something that we can do to improve the experience of contributors (especially new contributors) priority:p2 labels Aug 8, 2020
@anuraaga
Copy link
Contributor

anuraaga commented Aug 9, 2020

Weird that some tests do retry and some (akka only?) don't. Filed gradle/test-retry-gradle-plugin#64

@anuraaga
Copy link
Contributor

anuraaga commented Aug 9, 2020

While AkkaExecutorInstrumentationTest was easy to repro locally unfortunately I couldn't repro for AkkaHttpServerInstrumentationTestAsync.

@trask
Copy link
Member Author

trask commented Apr 3, 2021

Closing, haven't seen this issue in a while.

@trask trask closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor experience Something that we can do to improve the experience of contributors (especially new contributors)
Projects
None yet
Development

No branches or pull requests

2 participants