fix spring-webflux cast to PathPattern throws ClassCastException #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/easycla |
wang007
force-pushed
the
fix-webflux-cast-exception
branch
3 times, most recently
from
70e9d51 to
727bb49
Compare
mateuszrzeszutek
approved these changes
Oct 14, 2022
|
Hey @wang007 , |
wang007
force-pushed
the
fix-webflux-cast-exception
branch
from
727bb49 to
29ce07e
Compare
|
Hey @mateuszrzeszutek |
|
Thanks! |
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 22, 2022
…n-telemetry#6872) when ServerWebExchange.getAttributes().put(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE, "path string type"). opentelemetry javaagent will throw exception. [企业微信截图_76344afd-4541-482c-a90f-0606ad720351](https://user-images.githubusercontent.com/15957476/195615160-45559fb5-5e0c-4c25-8678-7d8aa603f346.png)
|
hey, @trask |
|
This fix will be included in the 1.20 release, which is scheduled to happen around 16th Nov |
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…n-telemetry#6872) when ServerWebExchange.getAttributes().put(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE, "path string type"). opentelemetry javaagent will throw exception. [企业微信截图_76344afd-4541-482c-a90f-0606ad720351](https://user-images.githubusercontent.com/15957476/195615160-45559fb5-5e0c-4c25-8678-7d8aa603f346.png)
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…n-telemetry#6872) when ServerWebExchange.getAttributes().put(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE, "path string type"). opentelemetry javaagent will throw exception. [企业微信截图_76344afd-4541-482c-a90f-0606ad720351](https://user-images.githubusercontent.com/15957476/195615160-45559fb5-5e0c-4c25-8678-7d8aa603f346.png)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when ServerWebExchange.getAttributes().put(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE, "path string type").
opentelemetry javaagent will throw exception.
企业微信截图_76344afd-4541-482c-a90f-0606ad720351