fix spring-webflux cast to PathPattern throws ClassCastException

open-telemetry · Oct 21, 2022 · 29ce07e · 29ce07e
1 parent 7104290
commit 29ce07e
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/...a/io/opentelemetry/javaagent/instrumentation/spring/webflux/server/WebfluxSingletons.java b/...a/io/opentelemetry/javaagent/instrumentation/spring/webflux/server/WebfluxSingletons.java
@@ -41,9 +41,14 @@ public static Instrumenter<Object, Void> instrumenter() {
 
   public static HttpRouteGetter<ServerWebExchange> httpRouteGetter() {
     return (context, exchange) -> {
-      PathPattern bestPattern =
-          exchange.getAttribute(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE);
-      return bestPattern == null ? null : bestPattern.getPatternString();
+      Object bestPatternObj = exchange.getAttribute(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE);
+      if (bestPatternObj == null) {
+        return null;
+      }
+      if (bestPatternObj instanceof PathPattern) {
+        return ((PathPattern) bestPatternObj).getPatternString();
+      }
+      return bestPatternObj.toString();
     };
   }