-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gradle-plugins from 1.9.1-alpha to 1.18.0-alpha in /conventions #6736
Bump gradle-plugins from 1.9.1-alpha to 1.18.0-alpha in /conventions #6736
Conversation
Bumps [gradle-plugins](https://github.com/open-telemetry/opentelemetry-java-instrumentation) from 1.9.1-alpha to 1.18.0-alpha. - [Release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-java-instrumentation/commits) --- updated-dependencies: - dependency-name: io.opentelemetry.instrumentation:gradle-plugins dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
@laurit I'm wondering now if the snapshot repo was on purpose so that we could update the gradle-plugins and use those updates immediately instead of waiting for a release (in which case we could bring back the snapshot repo and keep this version in sync with the latest SNAPSHOT) |
I thought we hade some dependency substitution magic so it really didn't matter what version is used here, it would still used the version that is built from source. See https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/conventions/settings.gradle.kts I don't pretend to fully understand how this works so I'd be fine with reintroducing the snapshot repo if you believe that it is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting to merge #6775, then will have dependabot recreate this PR and see what it says
@dependabot rebase |
Looks like io.opentelemetry.instrumentation:gradle-plugins is no longer a dependency, so this is no longer needed. |
Bumps gradle-plugins from 1.9.1-alpha to 1.18.0-alpha.
Release notes
Sourced from gradle-plugins's releases.
... (truncated)
Changelog
Sourced from gradle-plugins's changelog.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)