Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gradle-plugins from 1.9.1-alpha to 1.19.0-alpha-SNAPSHOT in /conventions #6658

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 19, 2022

Bumps gradle-plugins from 1.9.1-alpha to 1.19.0-alpha-SNAPSHOT.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team September 19, 2022 18:14
implementation("io.opentelemetry.instrumentation:gradle-plugins:1.9.1-alpha")
implementation("io.opentelemetry.instrumentation:gradle-plugins:1.19.0-alpha-SNAPSHOT")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@trask
Copy link
Member

trask commented Sep 20, 2022

@dependabot recreate

Bumps gradle-plugins from 1.9.1-alpha to 1.19.0-alpha-SNAPSHOT.

---
updated-dependencies:
- dependency-name: io.opentelemetry.instrumentation:gradle-plugins
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/conventions/io.opentelemetry.instrumentation-gradle-plugins-1.19.0-alpha-SNAPSHOT branch from 1ebd956 to 922d928 Compare September 20, 2022 00:18
@trask
Copy link
Member

trask commented Sep 20, 2022

I'm super lost why dependabot would be picking up a SNAPSHOT version, especially because my understanding is that it doesn't really have any gradle smarts, and so just regexing and comparing against known repositories

@trask
Copy link
Member

trask commented Sep 20, 2022

Or maybe it's on to something, the build is passing......... 🤔

@mateuszrzeszutek
Copy link
Member

I think it's because of

  maven {
    url = uri("https://oss.sonatype.org/content/repositories/snapshots")
  }

in the repositories section -- dependabot is smart enough to know where to get artifacts from.

trask pushed a commit that referenced this pull request Sep 24, 2022
I suspect it is not needed. Should avoid dependabot trying to use
snapshot dependencies like in
#6658
@trask
Copy link
Member

trask commented Sep 24, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 24, 2022

Superseded by #6736.

@dependabot dependabot bot closed this Sep 24, 2022
@dependabot dependabot bot deleted the dependabot/gradle/conventions/io.opentelemetry.instrumentation-gradle-plugins-1.19.0-alpha-SNAPSHOT branch September 24, 2022 02:56
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
I suspect it is not needed. Should avoid dependabot trying to use
snapshot dependencies like in
open-telemetry#6658
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
I suspect it is not needed. Should avoid dependabot trying to use
snapshot dependencies like in
open-telemetry#6658
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
I suspect it is not needed. Should avoid dependabot trying to use
snapshot dependencies like in
open-telemetry#6658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants