Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add daemon attribute to process.runtime.jvm.threads.count #6635

Merged
merged 2 commits into from
Sep 24, 2022

Conversation

tuhao1020
Copy link

Signed-off-by: HaoTu [email protected]

#6561 has closed

@tuhao1020 tuhao1020 requested a review from a team September 16, 2022 00:13
@tuhao1020
Copy link
Author

image

What is the problem? @trask

@trask
Copy link
Member

trask commented Sep 16, 2022

ya, this is not related to your PR, we will fix in main and let you know so you can pull in main after its fixed

@laurit
Copy link
Contributor

laurit commented Sep 18, 2022

@tuhao1020 jApiCmp issue should be fixed now, please rebase

@tuhao1020
Copy link
Author

@laurit done

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jack-berg @jonatan-ivanov PTAL

@trask
Copy link
Member

trask commented Sep 23, 2022

@tuhao1020 would you mind also submitting a PR to update the spec?

@tuhao1020
Copy link
Author

@trask
Copy link
Member

trask commented Sep 24, 2022

@trask trask merged commit 878dfc3 into open-telemetry:main Sep 24, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants