Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jvm memory and thread metric #6638

Closed
wzy531a opened this issue Sep 16, 2022 · 2 comments
Closed

Add jvm memory and thread metric #6638

wzy531a opened this issue Sep 16, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@wzy531a
Copy link

wzy531a commented Sep 16, 2022

jvm memory metric in runtime-metric only collect memoryPool, refer to splunk otel agent jvm memory metric:
p.r.jvm.memory.init
p.r.jvm.memory.max
p.r.jvm.memory.used
p.r.jvm.memory.committed

thread:
p.r.jvm.threads.live(Already exists)
p.r.jvm.threads.daemon
p.r.jvm.threads.peak
p.r.jvm.threads.states

About memory metric, I support Add JVM implementation information and memory semantic conventions, use p.r.j.memory.pool.* and p.r.j.memory.* to distinguish.

@wzy531a wzy531a added the enhancement New feature or request label Sep 16, 2022
@mateuszrzeszutek
Copy link
Member

Hey @wzy531a ,
With regards to memory metrics: MemoryPools and BufferPools offer pretty much the same information as Splunk's memory metrics (except the first two, these are a part of the memory profiling feature).
About the thread metrics: #6635 implements the daemon thread counter; the other two metrics are still not defined though.

@wzy531a
Copy link
Author

wzy531a commented Sep 16, 2022

Hey @wzy531a , With regards to memory metrics: MemoryPools and BufferPools offer pretty much the same information as Splunk's memory metrics (except the first two, these are a part of the memory profiling feature). About the thread metrics: #6635 implements the daemon thread counter; the other two metrics are still not defined though.

Both Splunk and Skywalking provide detailed metrics for memory and threads. So I think these metrics are necessary for memory and thread analysis.

@wzy531a wzy531a closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants