Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change play instrumentation name to play-mvc and restructure dirs #6106

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

breedx-splk
Copy link
Contributor

This is part of #4952

play renamed to play-mvc, and play-2.4 to play-mvc-2.4 (and same for 2.6).

Final structure looks like:

play/
  +---- play-mvc/
  |         +----- play-mvc-2.4/
  |         +----- play-mvc-2.6/
  |
  +---- play-ws/
            +----- play-ws-common/
            +----- play-ws-1.0/
            +----- play-ws-2.0/
            +----- play-ws-2.1/

I didn't change the actual instrumentation name, though. I didn't think we'd want that (would impact users who have chosen to disable it?)

@breedx-splk breedx-splk requested a review from a team May 27, 2022 18:35
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change the actual instrumentation name, though. I didn't think we'd want that (would impact users who have chosen to disable it?)

go ahead, we've still been changing the instrumentation names to match when we change the module names, and we doc it in the migration notes at the top of the release notes

@trask trask changed the title Restructure play instrumentation dirs. Change play instrumentation name to play-mvc and restructure dirs Jun 2, 2022
@trask
Copy link
Member

trask commented Jun 2, 2022

thx @breedx-splk!

@trask trask merged commit ee90c7c into open-telemetry:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants