Skip to content

Commit

Permalink
Change play instrumentation name to play-mvc and restructure dirs (#6106
Browse files Browse the repository at this point in the history
)

* restructure play instrumentation dirs

* change instrumentation name from play -> play-mvc

* Revert "change instrumentation name from play -> play-mvc"

This reverts commit 2174e09.

* spring-mvc names
  • Loading branch information
breedx-splk authored Jun 2, 2022
1 parent 30710ba commit ee90c7c
Show file tree
Hide file tree
Showing 48 changed files with 17 additions and 17 deletions.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public final class Play24Singletons {
private static final String SPAN_NAME = "play.request";
private static final Instrumenter<Void, Void> INSTRUMENTER =
Instrumenter.<Void, Void>builder(
GlobalOpenTelemetry.get(), "io.opentelemetry.play-2.4", s -> SPAN_NAME)
GlobalOpenTelemetry.get(), "io.opentelemetry.play-mvc-2.4", s -> SPAN_NAME)
.newInstrumenter();

public static Instrumenter<Void, Void> instrumenter() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
public class PlayInstrumentationModule extends InstrumentationModule {

public PlayInstrumentationModule() {
super("play", "play-2.4");
super("play", "play-mvc-2.4");
}

@Override
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public final class Play26Singletons {
private static final String SPAN_NAME = "play.request";
private static final Instrumenter<Void, Void> INSTRUMENTER =
Instrumenter.<Void, Void>builder(
GlobalOpenTelemetry.get(), "io.opentelemetry.play-2.6", s -> SPAN_NAME)
GlobalOpenTelemetry.get(), "io.opentelemetry.play-mvc-2.6", s -> SPAN_NAME)
.newInstrumenter();

@Nullable private static final Method typedKeyGetUnderlying;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
public class PlayInstrumentationModule extends InstrumentationModule {

public PlayInstrumentationModule() {
super("play", "play-2.6");
super("play", "play-mvc-2.6");
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ val scalaVersion = "2.12"
dependencies {
library("com.typesafe.play:play-ahc-ws-standalone_$scalaVersion:1.0.2")

implementation(project(":instrumentation:play-ws:play-ws-common:javaagent"))
implementation(project(":instrumentation:play:play-ws:play-ws-common:javaagent"))

testImplementation(project(":instrumentation:play-ws:play-ws-common:testing"))
testImplementation(project(":instrumentation:play:play-ws:play-ws-common:testing"))

// These are to ensure cross compatibility
testInstrumentation(project(":instrumentation:netty:netty-4.0:javaagent"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ val scalaVersion = "2.12"
dependencies {
library("com.typesafe.play:play-ahc-ws-standalone_$scalaVersion:2.0.0")

implementation(project(":instrumentation:play-ws:play-ws-common:javaagent"))
implementation(project(":instrumentation:play:play-ws:play-ws-common:javaagent"))

testImplementation(project(":instrumentation:play-ws:play-ws-common:testing"))
testImplementation(project(":instrumentation:play:play-ws:play-ws-common:testing"))

// These are to ensure cross compatibility
testInstrumentation(project(":instrumentation:netty:netty-4.0:javaagent"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ val scalaVersion = "2.12"
dependencies {
library("com.typesafe.play:play-ahc-ws-standalone_$scalaVersion:2.1.0")

implementation(project(":instrumentation:play-ws:play-ws-common:javaagent"))
implementation(project(":instrumentation:play:play-ws:play-ws-common:javaagent"))

testImplementation(project(":instrumentation:play-ws:play-ws-common:testing"))
testImplementation(project(":instrumentation:play:play-ws:play-ws-common:testing"))

// These are to ensure cross compatibility
testInstrumentation(project(":instrumentation:netty:netty-4.0:javaagent"))
Expand Down
14 changes: 7 additions & 7 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -345,13 +345,13 @@ include(":instrumentation:opentelemetry-instrumentation-api:testing")
include(":instrumentation:oshi:javaagent")
include(":instrumentation:oshi:library")
include(":instrumentation:oshi:testing")
include(":instrumentation:play:play-2.4:javaagent")
include(":instrumentation:play:play-2.6:javaagent")
include(":instrumentation:play-ws:play-ws-1.0:javaagent")
include(":instrumentation:play-ws:play-ws-2.0:javaagent")
include(":instrumentation:play-ws:play-ws-2.1:javaagent")
include(":instrumentation:play-ws:play-ws-common:javaagent")
include(":instrumentation:play-ws:play-ws-common:testing")
include(":instrumentation:play:play-mvc:play-mvc-2.4:javaagent")
include(":instrumentation:play:play-mvc:play-mvc-2.6:javaagent")
include(":instrumentation:play:play-ws:play-ws-1.0:javaagent")
include(":instrumentation:play:play-ws:play-ws-2.0:javaagent")
include(":instrumentation:play:play-ws:play-ws-2.1:javaagent")
include(":instrumentation:play:play-ws:play-ws-common:javaagent")
include(":instrumentation:play:play-ws:play-ws-common:testing")
include(":instrumentation:quartz-2.0:javaagent")
include(":instrumentation:quartz-2.0:library")
include(":instrumentation:quartz-2.0:testing")
Expand Down

0 comments on commit ee90c7c

Please sign in to comment.