Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gRPC dependency for export #4674

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Remove gRPC dependency for export #4674

merged 1 commit into from
Nov 19, 2021

Conversation

anuraaga
Copy link
Contributor

After

-rw-r--r--   1 aanuraag  staff  11747859 Nov 19 16:50 opentelemetry-javaagent-1.8.0-SNAPSHOT-slim.jar
-rw-r--r--   1 aanuraag  staff  15406177 Nov 19 16:50 opentelemetry-javaagent-1.8.0-SNAPSHOT.jar

Before

-rw-r--r--   1 aanuraag  staff  16673586 Nov 19 16:55 opentelemetry-javaagent-1.8.0-SNAPSHOT-slim.jar
-rw-r--r--   1 aanuraag  staff  24402582 Nov 19 16:55 opentelemetry-javaagent-1.8.0-SNAPSHOT.jar

@anuraaga
Copy link
Contributor Author

anuraaga commented Nov 19, 2021 •
edited
Loading

Found there was 200K cruft leftover

open-telemetry/opentelemetry-java#3918

Luckily the cruft doesn't also bring in Guava so rather than excluding now and removing exclusion later probably fine to lose the last few pounds next release.

trask
trask approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default artifact size 24402582 -> 15406177 😍

dependencyManagement/build.gradle.kts
Comment on lines -14 to -17
// IMPORTANT when updating otelVersion, make sure that grpcVersion below is >= the grpc version
// used by that otel version
val otelVersion = "1.9.0"
val grpcVersion = "1.41.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@trask trask merged commit bcae1b1 into open-telemetry:main Nov 19, 2021
@ryanrupp ryanrupp mentioned this pull request Jan 5, 2022
Closed
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@anuraaga @RashmiRam
Remove gRPC dependency for export (open-telemetry#4674)
cdab2c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iNikem iNikem iNikem approved these changes

@trask trask trask approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@laurit laurit Awaiting requested review from laurit

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anuraaga @trask @iNikem