Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gRPC from javaagent #4415

Closed
trask opened this issue Oct 18, 2021 · 2 comments
Closed

Remove gRPC from javaagent #4415

trask opened this issue Oct 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Oct 18, 2021

This should be possible now due to open-telemetry/opentelemetry-java#3684, and should reduce slim javaagent jar file by a nice 4mb.

@trask trask added the enhancement New feature or request label Oct 18, 2021
@ryanrupp
Copy link

ryanrupp commented Jan 5, 2022

Was this resolved by #4674? Was upgrading the agent and was just trying to see which changes moved requests from gRPC Netty --> OkHttp and found that PR and also this issue. Also looks like the PR change applies to both the regular and slim artifacts - think that was intended but I was just trying to understand the if there's any repercussions to consider there. Seemed like the gist of the linked issue is that gRPC java as a dependency is overkill for the serialization side of things so just skip and and use OkHttp directly. So I guess the only risk there is just a less tested code path possibly but this does ship as the default now for the agent.

@anuraaga
Copy link
Contributor

anuraaga commented Jan 5, 2022

Thanks @ryanrupp - indeed this was resolved by that PR. We originally were targeting slim with exporters like the jaeger one still using the heavyweight gRPC dependency at the time. All of that was cleaned up in the SDK though and we decided to remove from both. Your analysis Seemed like the gist of the linked issue is that gRPC java as a dependency is overkill for the serialization side of things so just skip and and use OkHttp directly. So I guess the only risk there is just a less tested code path possibly but this does ship as the default now for the agent. is spot-on, and hopefully by now it's been tested more since the 1.9.0 was first released.

@anuraaga anuraaga closed this as completed Jan 5, 2022
@anuraaga anuraaga changed the title Remove gRPC from slim javaagent Remove gRPC from javaagent Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants