Fix javaagent publishing #3929
Merged
Fix javaagent publishing #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
|
@mateuszrzeszutek it looks like |
| @@ -137,6 +132,7 @@ tasks { | |||
| archiveClassifier.set("") | |||
|
|
|||
| manifest { | |||
| attributes(jar.get().manifest.attributes) | |||
There was a problem hiding this comment.
I have absolutely no idea how this worked without this line before 🙈
trask
added a commit
that referenced
this pull request
Aug 24, 2021
* Fix javaagent publishing * Take manifest attributes from the jar task too Co-authored-by: Mateusz Rzeszutek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3900
I have no idea why, but when you have the default
shadowJarwith empty classifier it'll overwrite thejartask output and get attached to the maven publication properly. So I switched those two shadowJar tasks that we had: now the defaultshadowJarbuilds the javaagent without exporters, no classifier (previouslylightShadow); and a new custom shadow task builds the full javaagent with exporters and-allclassifier (previouslyshadowJar).It's similar to what was done in #3899, but we're publishing one more jar in this case.