Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-javaagent 1.5.0 published with packaging "pom" instead of "jar" #3900

Closed
trask opened this issue Aug 22, 2021 · 3 comments · Fixed by #3929
Closed

opentelemetry-javaagent 1.5.0 published with packaging "pom" instead of "jar" #3900

trask opened this issue Aug 22, 2021 · 3 comments · Fixed by #3929
Labels
bug Something isn't working

Comments

@trask
Copy link
Member

trask commented Aug 22, 2021

And opentelemetry-agent-for-testing too. opentelemetry-agent-for-testing was fixed in #3899

@trask trask added the bug Something isn't working label Aug 22, 2021
@iNikem
Copy link
Contributor

iNikem commented Aug 25, 2021

@trask @mateuszrzeszutek we are supposed to have an extension test which verifies this. Did not it work?

@mateuszrzeszutek
Copy link
Member

I'm guessing it didn't - the way the javaagent was built has changed some time ago (and the publishing issue was introduced at that time) and extension tests didn't fail on that at all.

@trask
Copy link
Member Author

trask commented Aug 26, 2021

I just check this, looks like the extension test worked because it uses the all classifier

If you remove the all classifier, e.g.

otel("io.opentelemetry.javaagent:opentelemetry-javaagent:1.5.0")

then ./gradlew compileJava fails.

If you change it to 1.5.1 (and still don't add the all classifier) now ./gradlew compileJava works.

So I think the solution is to the missing test is to switch the all and the default classifier 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants