Conversation
|
|
|
@aman99dex please sign the CLA so this contribution can be considered. |
|
Hey I think I fixed the cla part by signing the agreement |
If the signing is successful, #7737 (comment) will be automatically updated to the correct state. Please ensure that the information you sign with is the same as the information of all contributors in your commit logs. |
|
is there anything else i need to do after this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7737 +/- ##
=====================================
Coverage 86.2% 86.2%
=====================================
Files 302 302
Lines 21991 21996 +5
=====================================
+ Hits 18968 18974 +6
Misses 2642 2642
+ Partials 381 380 -1
🚀 New features to boost your workflow:
|
|
Duplicate with #7662 |
|
@aman99dex, can you please review #7662 which was created and reviewed prior this PR? |
Rewrote TestRecordDroppedAttributes to properly test limit-based drops separately from duplicate key drops
Updated TestApplyAttrLimitsDeduplication expectations to not count dedup drops
All tests pass.