Skip to content

fixed issue #6983#7737

Closed
aman99dex wants to merge 3 commits intoopen-telemetry:mainfrom
aman99dex:fix/issue6983
Closed

fixed issue #6983#7737
aman99dex wants to merge 3 commits intoopen-telemetry:mainfrom
aman99dex:fix/issue6983

Conversation

@aman99dex
Copy link
Copy Markdown

Rewrote TestRecordDroppedAttributes to properly test limit-based drops separately from duplicate key drops
Updated TestApplyAttrLimitsDeduplication expectations to not count dedup drops
All tests pass.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Dec 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aman99dex / name: Aman Gupta (378d889)

@aman99dex aman99dex marked this pull request as draft December 22, 2025 07:50
@aman99dex aman99dex marked this pull request as ready for review December 22, 2025 07:51
@pellared pellared added the blocked:CLA Waiting on CLA to be signed before progress can be made label Dec 22, 2025
@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Dec 22, 2025

@aman99dex please sign the CLA so this contribution can be considered.

@aman99dex
Copy link
Copy Markdown
Author

Hey I think I fixed the cla part by signing the agreement

@flc1125
Copy link
Copy Markdown
Member

flc1125 commented Dec 23, 2025

Hey I think I fixed the cla part by signing the agreement

If the signing is successful, #7737 (comment) will be automatically updated to the correct state.

Please ensure that the information you sign with is the same as the information of all contributors in your commit logs.

@aman99dex
Copy link
Copy Markdown
Author

is there anything else i need to do after this?

@MrAlias MrAlias removed the blocked:CLA Waiting on CLA to be signed before progress can be made label Dec 24, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.2%. Comparing base (655c08a) to head (7f9faf3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7737   +/-   ##
=====================================
  Coverage   86.2%   86.2%           
=====================================
  Files        302     302           
  Lines      21991   21996    +5     
=====================================
+ Hits       18968   18974    +6     
  Misses      2642    2642           
+ Partials     381     380    -1     
Files with missing lines Coverage Δ
sdk/log/record.go 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flc1125
Copy link
Copy Markdown
Member

flc1125 commented Dec 29, 2025

Duplicate with #7662

@flc1125 flc1125 added the duplicate This issue or pull request already exists label Dec 29, 2025
@pellared
Copy link
Copy Markdown
Member

pellared commented Jan 5, 2026

@aman99dex, can you please review #7662 which was created and reviewed prior this PR?

@pellared pellared closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants