sdk/log: fix "limit reached" logging and Record.DroppedAttributes by mexirica · Pull Request #7662 · open-telemetry/opentelemetry-go

mexirica · 2025-12-03T21:04:34Z

This pull request enhances logging and error reporting in the log record attribute handling code, specifically around dropped attributes and duplicate key-value pairs. The main focus is to provide clearer warnings when key-value pairs are dropped due to duplication, and to ensure warnings are only logged when actual drops occur.

Improved logging and error handling for dropped attributes and duplicate keys:

Added a new logKeyValuePairDropped warning (using sync.OnceFunc) to log a warning message when key-value pairs are dropped due to key duplication. This ensures that duplicate key drops are clearly reported.
Updated methods (addDropped, setDropped) to only log attribute drop warnings when the number of dropped attributes is greater than zero, preventing unnecessary log spam.

Enhancements to attribute deduplication logic:

Inserted calls to logKeyValuePairDropped in multiple places within AddAttributes, SetAttributes, and applyValueLimitsAndDedup to log a warning whenever key-value pairs are dropped due to duplication, ensuring better visibility into attribute handling issues.

Code cleanup:

Removed redundant calls to addDropped after deduplication, as the logging is now handled directly where drops occur.

codecov · 2025-12-03T21:09:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.1%. Comparing base (b992082) to head (f594bc8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #7662     +/-   ##
=======================================
- Coverage   86.1%   86.1%   -0.1%     
=======================================
  Files        302     302             
  Lines      22042   22046      +4     
=======================================
+ Hits       18990   18991      +1     
- Misses      2672    2674      +2     
- Partials     380     381      +1

Files with missing lines	Coverage Δ
sdk/log/record.go	`100.0% <100.0%> (ø)`

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Clarify log message fix for dropped key-value pairs.

pellared

The new tests looks like created with help of GenAI. Can you check it there is no redundancy and try to minimize the amount of new tests? At the same time I do not want to increase the complexity of existing tests (I think it is better to have more tests then fewer that are more complex).

pellared · 2025-12-22T09:01:51Z

@mexirica , are you able to address the comments?

mexirica · 2025-12-25T00:14:15Z

@mexirica , are you able to address the comments?

Hi, sorry for the delay, Will fix they

mexirica · 2025-12-26T18:40:29Z

The new tests looks like created with help of GenAI. Can you check it there is no redundancy and try to minimize the amount of new tests? At the same time I do not want to increase the complexity of existing tests (I think it is better to have more tests then fewer that are more complex).

Reduced the number of tests. If that's still not okay, I can clean up more.

pellared · 2026-01-08T16:58:55Z

@mexirica, kindly remainder 😉

Also Happy New Year 🎉

Co-authored-by: Robert Pająk <pellared@hotmail.com>

mexirica · 2026-01-08T20:52:14Z

@mexirica, kindly remainder 😉

Also Happy New Year 🎉

Happy New Year for you too, excuse me for the delay

pellared

@mexirica, last suggestions from my side (I already applied them). I don’t want to gold-plate this any further. Thanks a lot for your work.

@open-telemetry/go-approvers, could you please take a look? I do not think we need a separate PR for each bug.
Fixing one bug was impacting/causing next one. Also reviewing code that contained bugs was very hard to reason about. It would be great if this could land in the upcoming release (hopefully next week).

mexirica · 2026-01-09T10:54:20Z

@mexirica, last suggestions from my side (I already applied them). I don’t want to gold-plate this any further. Thanks a lot for your work.

@open-telemetry/go-approvers, could you please take a look? I do not think we need a separate PR for each bug. Fixing one bug was impacting/causing next one. Also reviewing code that contained bugs was very hard to reason about. It would be great if this could land in the upcoming release (hopefully next week).

Thank you and sorry for the time i took to resolve the issue.

pellared · 2026-01-09T10:57:47Z

sorry for the time i took to resolve the issue.

No need to feel sorry. I am really grateful 🏅

pellared · 2026-01-09T18:02:11Z

Planning to merge on Monday.

### Added - Add `Enabled` method to all synchronous instrument interfaces (`Float64Counter`, `Float64UpDownCounter`, `Float64Histogram`, `Float64Gauge`, `Int64Counter`, `Int64UpDownCounter`, `Int64Histogram`, `Int64Gauge`,) in `go.opentelemetry.io/otel/metric`. This stabilizes the synchronous instrument enabled feature, allowing users to check if an instrument will process measurements before performing computationally expensive operations. (#7763) - Add `AlwaysRecord` sampler in `go.opentelemetry.io/otel/sdk/trace`. (#7724) - Add `go.opentelemetry.io/otel/semconv/v1.39.0` package. The package contains semantic conventions from the `v1.39.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](https://github.com/open-telemetry/opentelemetry-go/blob/298cbedf256b7a9ab3c21e41fc5e3e6d6e4e94aa/semconv/v1.39.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.38.0.` (#7783, #7789) ### Changed - `Exporter` in `go.opentelemetry.io/otel/exporter/prometheus` ignores metrics with the scope `go.opentelemetry.io/contrib/bridges/prometheus`. This prevents scrape failures when the Prometheus exporter is misconfigured to get data from the Prometheus bridge. (#7688) - Improve performance of concurrent histogram measurements in `go.opentelemetry.io/otel/sdk/metric`. (#7474) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/stdout/stdoutmetric`. (#7492) - Improve the concurrent performance of `HistogramReservoir` in `go.opentelemetry.io/otel/sdk/metric/exemplar` by 4x. (#7443) - Improve performance of concurrent synchronous gauge measurements in `go.opentelemetry.io/otel/sdk/metric`. (#7478) - Improve performance of concurrent exponential histogram measurements in `go.opentelemetry.io/otel/sdk/metric`. (#7702) - Improve the concurrent performance of `FixedSizeReservoir` in `go.opentelemetry.io/otel/sdk/metric/exemplar`. (#7447) - The `rpc.grpc.status_code` attribute in the experimental metrics emitted from `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` is replaced with the `rpc.response.status_code` attribute to align with the semantic conventions. (#7854) - The `rpc.grpc.status_code` attribute in the experimental metrics emitted from `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc` is replaced with the `rpc.response.status_code` attribute to align with the semantic conventions. (#7854) ### Fixed - Fix bad log message when key-value pairs are dropped because of key duplication in `go.opentelemetry.io/otel/sdk/log`. (#7662) - Fix `DroppedAttributes` on `Record` in `go.opentelemetry.io/otel/sdk/log` to not count the non-attribute key-value pairs dropped because of key duplication. (#7662) - Fix `SetAttributes` on `Record` in `go.opentelemetry.io/otel/sdk/log` to not log that attributes are dropped when they are actually not dropped. (#7662) - `WithHostID` detector in `go.opentelemetry.io/otel/sdk/resource` to use full path for `ioreg` command on Darwin (macOS). (#7818) - Fix missing `request.GetBody` in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` to correctly handle HTTP2 GOAWAY frame. (#7794) ### Deprecated - Deprecate `go.opentelemetry.io/otel/exporters/zipkin`. For more information, see the [OTel blog post deprecating the Zipkin exporter](https://opentelemetry.io/blog/2025/deprecating-zipkin-exporters/). (#7670) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix dedup key log msg and add tests

74308d5

mexirica added 2 commits December 3, 2025 22:10

clean comments in tests

89d2390

add changelog

88668ea

mexirica changed the title ~~[WIP] Fix bad error log~~ Fix bad error log Dec 4, 2025

mexirica marked this pull request as ready for review December 4, 2025 18:30

mexirica requested review from MrAlias, XSAM, dashpole, dmathieu, flc1125 and pellared as code owners December 4, 2025 18:30

mexirica and others added 5 commits December 4, 2025 19:30

Merge branch 'main' into bad-log-duplicated-key

014d4a1

Merge branch 'main' into bad-log-duplicated-key

73fc768

Update changelog entry

7eececd

Update CHANGELOG.md

065756e

Update CHANGELOG for key-value pair duplication fix

1ab60b4

Clarify log message fix for dropped key-value pairs.

pellared reviewed Dec 9, 2025

View reviewed changes

Comment thread sdk/log/record_test.go

Comment thread sdk/log/record.go Outdated

Comment thread sdk/log/record_test.go Outdated

Comment thread sdk/log/record_test.go Outdated

Comment thread sdk/log/record_test.go Outdated

mexirica and others added 3 commits December 26, 2025 19:05

Rename test vars and moved descriptions field below name

764fc3f

minimize amount of written test

630b8fb

Merge branch 'main' into bad-log-duplicated-key

023c3fe

flc1125 mentioned this pull request Dec 29, 2025

fixed issue #6983 #7737

Closed

Merge branch 'main' into bad-log-duplicated-key

0c79983

pellared reviewed Jan 5, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

pellared reviewed Jan 5, 2026

View reviewed changes

Comment thread sdk/log/record.go Outdated

pellared reviewed Jan 5, 2026

View reviewed changes

Comment thread sdk/log/record_test.go Outdated

mexirica and others added 3 commits January 8, 2026 21:42

Update CHANGELOG.md

abe6f02

Co-authored-by: Robert Pająk <pellared@hotmail.com>

remove setDropped method

6fd3a23

Remove TestDroppedLoggingOnlyWhenNonZero test method

79ee73e

mexirica and others added 3 commits January 8, 2026 22:03

Merge branch 'main' into bad-log-duplicated-key

d5a4e50

fix linter

8addc85

Merge branch 'main' into bad-log-duplicated-key

e65e47b

pellared approved these changes Jan 9, 2026

View reviewed changes

Comment thread sdk/log/record_test.go Outdated

Comment thread sdk/log/record_test.go Outdated

Comment thread sdk/log/record_test.go

Comment thread sdk/log/record_test.go Outdated

Apply suggestions from code review

3b3fe59

pellared added this to the v1.40.0 milestone Jan 9, 2026

pellared changed the title ~~Fix bad error log~~ sdk/log: fix "limit reached" logging and DroppedAttributes Jan 9, 2026

pellared changed the title ~~sdk/log: fix "limit reached" logging and DroppedAttributes~~ sdk/log: fix "limit reached" logging and Record.DroppedAttributes Jan 9, 2026

Update CHANGELOG.md

2fcb736

dmathieu approved these changes Jan 9, 2026

View reviewed changes

Merge branch 'main' into bad-log-duplicated-key

f594bc8

pellared merged commit f98af48 into open-telemetry:main Jan 13, 2026
33 checks passed

MrAlias mentioned this pull request Feb 2, 2026

Release v1.40.0 #7859

Merged

This was referenced Mar 3, 2026

Bump go.opentelemetry.io/otel/sdk from 1.37.0 to 1.40.0 in /flytectl flyteorg/flyte#6959

Open

Bump go.opentelemetry.io/otel/sdk from 1.35.0 to 1.40.0 in /flytecopilot flyteorg/flyte#6960

Open

Conversation

mexirica commented Dec 3, 2025

Uh oh!

codecov bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pellared left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pellared commented Dec 22, 2025

Uh oh!

mexirica commented Dec 25, 2025

Uh oh!

mexirica commented Dec 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pellared commented Jan 8, 2026

Uh oh!

mexirica commented Jan 8, 2026

Uh oh!

pellared left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mexirica commented Jan 9, 2026

Uh oh!

pellared commented Jan 9, 2026

Uh oh!

pellared commented Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Dec 3, 2025 •

edited

Loading

pellared left a comment •

edited

Loading

pellared left a comment •

edited

Loading