We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httpconv
netconv
Alternative proposal for #3744
gotmpl
semconvkit
Makefile
semconv/internal
This should decouple semconv package from the instrumentation libraries and make the creation of new semconv packages easier.
The text was updated successfully, but these errors were encountered:
Instead of point 2 and 3 we just need to stop generating new packages. The semconvkit tool is still needed for generating files like: https://github.com/open-telemetry/opentelemetry-go/blob/main/semconv/v1.20.0/schema.go
Sorry, something went wrong.
pellared
Successfully merging a pull request may close this issue.
Alternative proposal for #3744
httpconv
andnetconv
in https://github.com/open-telemetry/opentelemetry-go-contrib1.1. They should be internal and we can possibly use the
gotmpl
tool to avoid cross-module dependencies (reference: Do not depend on internal packages of different modules #3846)1.2. The package would just operate on the "latest" (the one currently supported in go-contrib repo) version of semconv
1.3. Update https://github.com/open-telemetry/opentelemetry-go-contrib instrumentation libraries to use the new packages
2.1. Remove
semconvkit
tool and its usage fromMakefile
semconv/internal
packagesThis should decouple semconv package from the instrumentation libraries and make the creation of new semconv packages easier.
The text was updated successfully, but these errors were encountered: