-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default Jaeger collector endpoint #1898
Fix default Jaeger collector endpoint #1898
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1898 +/- ##
=======================================
- Coverage 79.4% 79.4% -0.1%
=======================================
Files 139 139
Lines 7418 7418
=======================================
- Hits 5894 5892 -2
- Misses 1278 1280 +2
Partials 246 246
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can you update the otel-collector to use this endpoint as well?
I can take a look in the following days. |
@pellared I was referrering to:
But, on second look, it looks like this is actually using the collector's gRPC exporter for Jaeger. So nothing to actually change. |
Why
The current default value of the Jaeger collector endpoint is wrong as it points to gRPC endpoint. See: https://www.jaegertracing.io/docs/1.22/getting-started/
What
Set the default endpoint to
:14268/api/traces
as suggested in https://www.jaegertracing.io/docs/1.22/apis/#thrift-over-http-stableTesting
I started Jaeger like this:
And created little program to set the exporter and make a sample span.