Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default Jaeger collector endpoint #1898

Merged
merged 2 commits into from
May 12, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented May 11, 2021

Why

The current default value of the Jaeger collector endpoint is wrong as it points to gRPC endpoint. See: https://www.jaegertracing.io/docs/1.22/getting-started/

What

Set the default endpoint to :14268/api/traces as suggested in https://www.jaegertracing.io/docs/1.22/apis/#thrift-over-http-stable

Testing

I started Jaeger like this:

$ docker run -d --name jaeger \
  -e COLLECTOR_ZIPKIN_HOST_PORT=:9411 \
  -p 5775:5775/udp \
  -p 6831:6831/udp \
  -p 6832:6832/udp \
  -p 5778:5778 \
  -p 16686:16686 \
  -p 14268:14268 \
  -p 14250:14250 \
  -p 9411:9411 \
  jaegertracing/all-in-one:1.22

And created little program to set the exporter and make a sample span.

image

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #1898 (edd3030) into main (1e3fa3a) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1898     +/-   ##
=======================================
- Coverage   79.4%   79.4%   -0.1%     
=======================================
  Files        139     139             
  Lines       7418    7418             
=======================================
- Hits        5894    5892      -2     
- Misses      1278    1280      +2     
  Partials     246     246             
Impacted Files Coverage Δ
exporters/trace/jaeger/uploader.go 50.6% <100.0%> (ø)
exporters/trace/jaeger/jaeger.go 93.4% <0.0%> (-1.1%) ⬇️

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you update the otel-collector to use this endpoint as well?

@pellared
Copy link
Member Author

pellared commented May 11, 2021

This looks good. Can you update the otel-collector to use this endpoint as well?

I can take a look in the following days.

@Aneurysm9 Aneurysm9 merged commit cabf0c0 into open-telemetry:main May 12, 2021
@pellared pellared deleted the fix-jaeger-endpoint-url branch May 12, 2021 05:12
@MrAlias
Copy link
Contributor

MrAlias commented May 12, 2021

@pellared I was referrering to:

But, on second look, it looks like this is actually using the collector's gRPC exporter for Jaeger. So nothing to actually change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants