Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL_EXPORTER_JAEGER_ENDPOINT sdk env option has wrong default value #1871

Closed
blumamir opened this issue Aug 17, 2021 · 3 comments
Closed

OTEL_EXPORTER_JAEGER_ENDPOINT sdk env option has wrong default value #1871

blumamir opened this issue Aug 17, 2021 · 3 comments
Assignees
Labels
area:sdk Related to the SDK spec:miscellaneous For issues that don't match any other spec label spec:trace Related to the specification/trace directory

Comments

@blumamir
Copy link
Member

According to the spec, the default value for OTEL_EXPORTER_JAEGER_ENDPOINT should be http://localhost:14250.

According to Jaeger website, port 14250 is used to send spans in model.proto format, where port 14268 "accept jaeger.thrift directly from clients".

In GO sdk, the default value is different from the specification: "http://localhost:14268/api/traces".

This PR changed it and explains why the value in the spec is not correct.

JS sdk is also mentioning the 14268 endpoint here instead of the default 14250.

I suspect that the value should change in spec from http://localhost:14250 to http://localhost:14268/api/traces

@blumamir blumamir added the spec:miscellaneous For issues that don't match any other spec label label Aug 17, 2021
@carlosalberto
Copy link
Contributor

cc @yurishkuro

@carlosalberto carlosalberto added area:sdk Related to the SDK spec:trace Related to the specification/trace directory labels Aug 17, 2021
@srikanthccv
Copy link
Member

I believe it is 14268 for thrift over http and 14250 for proto over grpc. See the related exporter selection where known value jaeger for OTEL_TRACES_EXPORTER recommends using Jaeger gRPC.

@blumamir
Copy link
Member Author

exporter selection

Thanks for the reference. Wonder why GO and JS choose to export via thrift and not gRPC.
Anyhow it's not related to this issue I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:miscellaneous For issues that don't match any other spec label spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

4 participants