breaking(zipkin): removes serviceName from zipkin exporter.#1697
Merged
Aneurysm9 merged 5 commits intoopen-telemetry:mainfrom Mar 16, 2021
Merged
Conversation
Resource detector provides a serviceName in all cases, hence we can relay on span resource to obtain the serviceName. Also this is required by the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md\#service-name (open-telemetry#1549).
jcchavezs
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
lizthegrey
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
- Coverage 77.8% 77.8% -0.1%
=======================================
Files 130 130
Lines 6986 6988 +2
=======================================
+ Hits 5437 5438 +1
- Misses 1298 1299 +1
Partials 251 251
|
bogdandrutu
approved these changes
Mar 12, 2021
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
My LGTM does not count, but I like giving it 👍
| - `"go.opentelemetry.io/sdk/metric/controller.basic".WithPusher` is replaced with `WithExporter` to provide consistent naming across project. (#1656) | ||
| - Added non-empty string check for trace `Attribute` keys. (#1659) | ||
| - Add `description` to SpanStatus only when `StatusCode` is set to error. (#1662) | ||
| - Removes `serviceName` parameter from Zipkin exporter and uses resource instead. (#1549) |
Member
There was a problem hiding this comment.
Not sure about the standard, but I see all using "Remove" here :)
Member
There was a problem hiding this comment.
This line should move to the Removed section.
XSAM
requested changes
Mar 13, 2021
Member
XSAM
left a comment
XSAM
left a comment
There was a problem hiding this comment.
Looks good. But we should update example/zipkin/main.go as well.
| - `"go.opentelemetry.io/sdk/metric/controller.basic".WithPusher` is replaced with `WithExporter` to provide consistent naming across project. (#1656) | ||
| - Added non-empty string check for trace `Attribute` keys. (#1659) | ||
| - Add `description` to SpanStatus only when `StatusCode` is set to error. (#1662) | ||
| - Removes `serviceName` parameter from Zipkin exporter and uses resource instead. (#1549) |
Member
There was a problem hiding this comment.
This line should move to the Removed section.
Contributor
Author
|
Done.
…On Sat, 13 Mar 2021, 02:01 Sam Xie, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good. But we should update example/zipkin/main.go as well.
------------------------------
In CHANGELOG.md
<#1697 (comment)>
:
> @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- `"go.opentelemetry.io/sdk/metric/controller.basic".WithPusher` is replaced with `WithExporter` to provide consistent naming across project. (#1656)
- Added non-empty string check for trace `Attribute` keys. (#1659)
- Add `description` to SpanStatus only when `StatusCode` is set to error. (#1662)
+- Removes `serviceName` parameter from Zipkin exporter and uses resource instead. (#1549)
This line should move to the Removed section.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1697 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAVITMPWRFOUHDMLRCTTDK2NTANCNFSM4ZC4XRWQ>
.
|
XSAM
approved these changes
Mar 14, 2021
jcchavezs
added a commit
to hypertrace/goagent
that referenced
this pull request
Aug 19, 2021
It was required for zipkin exporter but not anymore, see open-telemetry/opentelemetry-go#1697.
jcchavezs
changed the title
jcchavezs
added a commit
to hypertrace/goagent
that referenced
this pull request
Aug 19, 2021
* chore: removes service name as parameter for exporter It was required for zipkin exporter but not anymore, see open-telemetry/opentelemetry-go#1697. * chore: adds check for Go 1.16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource detector provides a serviceName in all cases, hence we can relay on span resource to obtain the serviceName. Also this is required by the spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md\#service-name
Closes #1549