chore: removes service name as parameter for exporter#131
Merged
Conversation
It was required for zipkin exporter but not anymore, see open-telemetry/opentelemetry-go#1697.
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 32 32
Lines 952 952
=======================================
Hits 566 566
Misses 337 337
Partials 49 49
Continue to review full report at Codecov.
|
prodion23
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was required for zipkin exporter but not anymore, see open-telemetry/opentelemetry-go#1697.