SDK span no modification after ended #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make note of methods that do nothing if span is not recording.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1543 +/- ##
=====================================
Coverage 78.0% 78.0%
=====================================
Files 127 127
Lines 6590 6590
=====================================
Hits 5146 5146
Misses 1200 1200
Partials 244 244
|
Aneurysm9
approved these changes
Feb 17, 2021
XSAM
approved these changes
Feb 17, 2021
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
* Document SDK span ending stops recording * Guard SDK span set methods with record check * Document SDK span exported API Make note of methods that do nothing if span is not recording. * Document SDK span End recording check * Document the SetName method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the last few details of #1313. Most of the work was completed in #1360
Resolves #1313