Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK Span updates should be ignored after End is called #1313

Closed
MrAlias opened this issue Nov 6, 2020 · 2 comments · Fixed by #1543
Closed

SDK Span updates should be ignored after End is called #1313

MrAlias opened this issue Nov 6, 2020 · 2 comments · Fixed by #1543
Assignees
@MrAlias
Labels
area:trace Part of OpenTelemetry tracing bug Something isn't working pkg:SDK Related to an SDK package
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Nov 6, 2020 •
edited
Loading

The following methods of the SDK span need to be updated to not perform an action if called after the End method has been called and the documentation for the methods need to include this information.

  • AddEvent
  • RecordError
  • SetAttributes
  • SetName
  • SetStatus
  • addLinks
  • addChild
@MrAlias MrAlias added bug Something isn't working pkg:SDK Related to an SDK package area:trace Part of OpenTelemetry tracing labels Nov 6, 2020
@MrAlias MrAlias added this to the RC1 milestone Nov 6, 2020
@MrAlias MrAlias self-assigned this Nov 6, 2020
@MrAlias MrAlias removed their assignment Nov 19, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 16, 2021

Need to verify, but this might have been resolved when we changed to a read-only span export type.

@MrAlias MrAlias self-assigned this Feb 16, 2021
@MrAlias MrAlias mentioned this issue Feb 17, 2021
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 17, 2021

Most of the work complete in #1360, #1543 documents things and cleans up some checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:trace Part of OpenTelemetry tracing bug Something isn't working pkg:SDK Related to an SDK package
Projects
None yet
Milestone
RC1
Development

Successfully merging a pull request may close this issue.

SDK span no modification after ended MrAlias/opentelemetry-go
1 participant
@MrAlias