Rename attributesMap.go to follow convention#1343
Closed
johananl wants to merge 1 commit intoopen-telemetry:masterfrom
Closed
Rename attributesMap.go to follow convention#1343johananl wants to merge 1 commit intoopen-telemetry:masterfrom
johananl wants to merge 1 commit intoopen-telemetry:masterfrom
Conversation
attributesMap.go uses camel case while we seem to be using snake case throughout the codebase. Use attributesmap.go and not attributes_map.go following evictedqueue.go which seems similar to attributesMap.go in nature.
johananl
requested review from
Aneurysm9,
MrAlias,
XSAM,
evantorrie,
jmacd and
lizthegrey
as code owners
Contributor
Author
|
I've added a changelog entry even though this seems like a trivial change to me that isn't very interesting to users who might read the changelog. Do we have any guidelines regarding what should go in the changelog? EDIT: Looks like we use the |
johananl
force-pushed
the
johananl/rename-attributesmap
branch
from
acf0efb to
f472a4c
Compare
Contributor
Contributor
Author
|
Oops, thanks @MrAlias. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attributesMap.gouses camel case while we seem to be using snake case throughout the codebase.Use
attributesmap.goand notattributes_map.gofollowingevictedqueue.gowhich seems similar toattributesMap.goin nature.Fixes #1335.