Add missing tests for attributesMap#1337
Merged
Aneurysm9 merged 7 commits intoopen-telemetry:masterfrom Nov 19, 2020
Merged
Conversation
dstdfx
requested review from
Aneurysm9,
MrAlias,
XSAM,
evantorrie,
jmacd and
lizthegrey
as code owners
Aneurysm9
approved these changes
Nov 16, 2020
MrAlias
approved these changes
Nov 16, 2020
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
dstdfx
force-pushed
the
attributes-map-tests
branch
from
19d3411 to
45c9edd
Compare
dashpole
reviewed
Nov 17, 2020
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1337 +/- ##
========================================
- Coverage 77.8% 77.5% -0.4%
========================================
Files 125 125
Lines 6107 6131 +24
========================================
Hits 4753 4753
- Misses 1103 1127 +24
Partials 251 251
|
XSAM
approved these changes
Nov 18, 2020
dashpole
approved these changes
Nov 18, 2020
| _, ok := attrMap.attributes[key] | ||
| if ok { | ||
| t.Fatal("should be dropped") | ||
| t.Errorf("key %q should be dropped", testKeyFmt) |
Contributor
There was a problem hiding this comment.
I think you want to print out key here, rather than the key format.
Merged
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
* Rename sdk/trace/attributesMap.go -> sdk/trace/attributesmap.go Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Add missing tests for attributesMap Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Update CHANGELOG.md Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Add missing license header Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Delete underscores in test names Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com> * Tests clean up Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing tests for attributesMap and also fixes #1335