Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offsetgen: support Docker username and password #1239

Merged
merged 3 commits into from
Nov 5, 2024
Merged

offsetgen: support Docker username and password #1239

merged 3 commits into from
Nov 5, 2024

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Nov 4, 2024

Fixes #435

Allows you to set DOCKER_USERNAME and DOCKER_PASSWORD to authenticate with docker hub on pull. Note that a PAT can also be used for password

@damemi damemi requested a review from a team as a code owner November 4, 2024 21:28
RonFed
RonFed approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@RonFed RonFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Do we need to update the Makefile for this to work with something like:
DOCKER_USERNAME=<username> DOCKER_PASSWORD=<password> make docker-offsets?

@damemi damemi merged commit 5da8ee5 into open-telemetry:main Nov 5, 2024
26 checks passed
@MrAlias MrAlias added this to the v0.17.0-alpha milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@RonFed RonFed RonFed approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
v0.17.0-alpha
Development

Successfully merging this pull request may close these issues.

Support docker credentials in offsetgen
3 participants
@damemi @MrAlias @RonFed