Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support docker credentials in offsetgen #435

Closed
MrAlias opened this issue Oct 30, 2023 · 1 comment · Fixed by #1239
Closed

Support docker credentials in offsetgen #435

MrAlias opened this issue Oct 30, 2023 · 1 comment · Fixed by #1239
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Oct 30, 2023

Is your feature request related to a problem? Please describe.

When a developer runs a full offset update, or tries to add a new offset, on a new system without a cache of all the docker images of Go Dockerhub will rate-limit their requests for containers. This is something like 100 pulls a day, but more requests are needed for a completely new setup.

Describe the solution you'd like

Support user authentication in offsetgen. If it is set in the CLI or via the environment use that auth to pull images so the rate limit is not a blocker.

Describe alternatives you've considered

Currently you can work around this by authenticating with the docker CLI and just manually pulling all the images you need.

Additional context

https://docs.docker.com/docker-hub/download-rate-limit/

@MrAlias MrAlias added enhancement New feature or request help wanted Extra attention is needed labels Oct 30, 2023
@damemi
Copy link
Contributor

damemi commented Nov 4, 2024

I'm hitting this now so just wanted to share what I've found: I think the docker functions like ImagePull have an Options struct that takes encoded registry auth credentials. Seems like we need to get the docker auth credentials locally at startup, base64 encode them, and pass them to these functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants