Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoding tests to the telemetry package #1196

Merged
merged 6 commits into from
Oct 19, 2024
Merged

Add encoding tests to the telemetry package #1196

merged 6 commits into from
Oct 19, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 15, 2024 •
edited
Loading

  • Test all types can be marshaled into expected JSON
  • Test all types can be unmarshaled with CamelCase field names
  • Test all types can be unmarshaled with snake_case field names

Fixes

  • Handles flags in span links
  • Decodes snake_case for scopes
  • Does not drop the required name of a span if it is empty
  • Handles zero time values
  • Omits parent span IDs if empty

@MrAlias MrAlias marked this pull request as ready for review October 15, 2024 14:56
@MrAlias MrAlias requested a review from a team as a code owner October 15, 2024 14:56
@MrAlias MrAlias mentioned this pull request Oct 15, 2024
Merged
pellared
pellared approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@MrAlias MrAlias merged commit 756cc23 into open-telemetry:main Oct 19, 2024
26 checks passed
@MrAlias MrAlias deleted the test-encoding branch October 19, 2024 15:20
@MrAlias MrAlias added this to the v0.16.0-alpha milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
v0.16.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@MrAlias @pellared @RonFed