Support span flags

open-telemetry · Oct 15, 2024 · dc9d1b7 · dc9d1b7
1 parent bd82957
commit dc9d1b7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/sdk/telemetry/span.go b/sdk/telemetry/span.go
@@ -442,6 +442,8 @@ func (sl *SpanLink) UnmarshalJSON(data []byte) error {
 			err = decoder.Decode(&sl.Attrs)
 		case "droppedAttributesCount", "dropped_attributes_count":
 			err = decoder.Decode(&sl.DroppedAttrs)
+		case "flags":
+			err = decoder.Decode(&sl.Flags)
 		default:
 			// Skip unknown.
 		}

diff --git a/sdk/telemetry/span_test.go b/sdk/telemetry/span_test.go
@@ -14,8 +14,7 @@ func TestSpanEncoding(t *testing.T) {
 		SpanID:       [8]byte{0x2},
 		TraceState:   "test=a",
 		ParentSpanID: [8]byte{0x1},
-		// https://github.com/open-telemetry/opentelemetry-collector/issues/11267
-		// Flags:             1,
+		Flags:        1,
 		Name:         "span.a",
 		Kind:         SpanKindClient,
 		StartTime:    y2k,
@@ -41,6 +40,7 @@ func TestSpanEncoding(t *testing.T) {
 		"traceId": "01000000000000000000000000000000",
 		"spanId": "0200000000000000",
 		"traceState": "test=a",
+		"flags": 1,
 		"name": "span.a",
 		"kind": 3,
 		"attributes": [
@@ -78,6 +78,7 @@ func TestSpanEncoding(t *testing.T) {
 		"trace_id": "01000000000000000000000000000000",
 		"span_id": "0200000000000000",
 		"trace_state": "test=a",
+		"flags": 1,
 		"name": "span.a",
 		"kind": 3,
 		"attributes": [
@@ -162,8 +163,7 @@ func TestSpanLinkEncoding(t *testing.T) {
 		TraceState:   "test=green",
 		Attrs:        []Attr{Int("queue", 17)},
 		DroppedAttrs: 8,
-		// https://github.com/open-telemetry/opentelemetry-collector/issues/11267
-		// Flags: 1,
+		Flags:        1,
 	}
 
 	t.Run("CamelCase", runJSONEncodingTests(link, []byte(`{
@@ -178,7 +178,8 @@ func TestSpanLinkEncoding(t *testing.T) {
 				}
 			}
 		],
-		"droppedAttributesCount": 8
+		"droppedAttributesCount": 8,
+		"flags": 1
 	}`)))
 
 	t.Run("SnakeCase", runJSONUnmarshalTest(link, []byte(`{
@@ -193,6 +194,7 @@ func TestSpanLinkEncoding(t *testing.T) {
 				}
 			}
 		],
-		"dropped_attributes_count": 8
+		"dropped_attributes_count": 8,
+		"flags": 1
 	}`)))
 }