Skip to content

Switch version from function to string in runtime#8359

Closed
jongwooo wants to merge 2 commits into
open-telemetry:mainfrom
jongwooo:switch-versions-from-functions-to-strings-in-runtime
Closed

Switch version from function to string in runtime#8359
jongwooo wants to merge 2 commits into
open-telemetry:mainfrom
jongwooo:switch-versions-from-functions-to-strings-in-runtime

Conversation

@jongwooo
Copy link
Copy Markdown
Member

@jongwooo jongwooo commented Jan 7, 2026

Change Version() func to const Version string in runtime

Part of #8272

@jongwooo jongwooo requested review from a team, dashpole and dmathieu as code owners January 7, 2026 06:11
@dmathieu
Copy link
Copy Markdown
Member

dmathieu commented Jan 7, 2026

This needs a changelog entry.

@jongwooo
Copy link
Copy Markdown
Member Author

jongwooo commented Jan 7, 2026

@dmathieu Thank you! I will also write changelogs for the other pull requests.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (e47aa57) to head (718c7ab).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8359     +/-   ##
=======================================
- Coverage   82.3%   82.3%   -0.1%     
=======================================
  Files        192     191      -1     
  Lines      13777   13775      -2     
=======================================
- Hits       11342   11340      -2     
  Misses      2030    2030             
  Partials     405     405             
Files with missing lines Coverage Δ
instrumentation/runtime/producer.go 86.2% <100.0%> (ø)
instrumentation/runtime/runtime.go 73.3% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jongwooo
Copy link
Copy Markdown
Member Author

jongwooo commented Jan 8, 2026

Hi team, it looks like this issue has already been addressed in #8349. I suggest closing this PR to avoid duplication.

@dmathieu dmathieu closed this Jan 8, 2026
@jongwooo jongwooo deleted the switch-versions-from-functions-to-strings-in-runtime branch January 8, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants