Skip to content

Switch version from function to string in runtime#8349

Merged
pellared merged 4 commits into
open-telemetry:mainfrom
carsontham:fix-instrumentation/runtime-version-to-const
Jan 9, 2026
Merged

Switch version from function to string in runtime#8349
pellared merged 4 commits into
open-telemetry:mainfrom
carsontham:fix-instrumentation/runtime-version-to-const

Conversation

@carsontham
Copy link
Copy Markdown
Member

@carsontham carsontham commented Jan 5, 2026

Fixes part of #8272
Updated instrumentation/runtime version from a function to a string constant

@carsontham carsontham requested review from a team, dashpole and dmathieu as code owners January 5, 2026 15:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (0948681) to head (7fe7cc5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8349     +/-   ##
=======================================
- Coverage   82.3%   82.2%   -0.1%     
=======================================
  Files        184     183      -1     
  Lines      13768   13766      -2     
=======================================
- Hits       11333   11320     -13     
- Misses      2030    2041     +11     
  Partials     405     405             
Files with missing lines Coverage Δ
instrumentation/runtime/producer.go 86.2% <100.0%> (ø)
instrumentation/runtime/runtime.go 73.3% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

@carsontham carsontham force-pushed the fix-instrumentation/runtime-version-to-const branch from f614271 to 465694e Compare January 5, 2026 15:44
Comment thread CHANGELOG.md
@pellared pellared changed the title Updated versions from functions to strings for instrumentation/runtime Switch version from function to string in runtime Jan 9, 2026
@pellared pellared merged commit 4847446 into open-telemetry:main Jan 9, 2026
29 checks passed
@MrAlias MrAlias added this to the v1.40.0 milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants